[Perpetual]: New Liquidation System #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
==========================================
+ Coverage 43.35% 43.62% +0.27%
==========================================
Files 640 641 +1
Lines 21127 21493 +366
==========================================
+ Hits 9160 9377 +217
- Misses 10892 11002 +110
- Partials 1075 1114 +39 |
| // TODO: Handle stop loss | ||
| ctx.EventManager().EmitEvent(sdk.NewEvent(types.EventClosePositions, | ||
| sdk.NewAttribute("liquidations", strings.Join(liqLog, "\n")), | ||
| //sdk.NewAttribute("stop_loss", strings.Join(closeLog, "\n")), |
There was a problem hiding this comment.
@amityadav0 can we get rid of that?
| return sdk.ZeroInt(), err | ||
| } | ||
| err = k.bankKeeper.SendCoins(ctx, ammPoolAddr, fundAddr, takeCoins) | ||
| //err := k.bankKeeper.SendCoinsFromModuleToAccount(ctx, ammPool.Address, fundAddr, takeCoins) |
There was a problem hiding this comment.
@amityadav0 can we get rid of this comment line?
cosmic-vagabond
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What has Changed?
What specific problem were you aiming to address, and how did you successfully resolve it? If tests were not uploaded for this pull request or if coverage decreased, please provide an explanation for the change.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking changeDeployment Notes
Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.
Screenshots and Videos
Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.